Re: [Xen-devel] [PATCH-4.5 v2 02/10] xen/arm: support HW interrupts in gic_set_lr

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-02-14 at 17:49 +0000, Julien Grall wrote:
> On 02/14/2014 03:51 PM, Stefano Stabellini wrote:
> > If the irq to be injected is an hardware irq (p->desc != NULL), set
> > GICH_LR_HW.
> > 
> > Remove the code to EOI a physical interrupt on behalf of the guest
> > because it has become unnecessary.
> > 
> > Also add a struct vcpu* parameter to gic_set_lr.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> 
> IRL you told me that this patch as dependency on another. It would be
> nice to mention this dependency in the commit message for bisection.

As in bisection is broken and needs manual intervention? Please don't do
that, reorder it or resplit things to make the issue go away.

The patch itself looks ok to me, but I won't ack until this is explained
or resolved.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel