Re: [Xen-devel] [PATCH 2/2] tools/console: xenconsole tolerate tty errors

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH 2/2] tools/console: xenconsole tolerate tty 
errors"):
> On Mon, 2014-03-17 at 16:24 +0000, Ian Jackson wrote:
> > Since 28d386fc4341 (XSA-57), libxl writes an empty value for the
> > console tty node, with read-only permission for the guest, when
> > setting up pv console "frontends".  (The actual tty value is later set
> > by xenconsoled.)   Writing an empty node is not strictly necessary to
> > stop the frontend from writing dangerous values here, but it is a good
> > belt-and-braces approach.
...
> >                     if (pty_path != NULL) {
> > -                           pty_fd = open(pty_path, O_RDWR | O_NOCTTY);
> > -                           if (pty_fd == -1)
> > -                                   err(errno, "Could not open tty `%s'", 
> > pty_path);
> > +                           if (pty_path[0] != '\0') {
> 
> Can the top-level condition not be
>       if ( pty_path != NULL && pty_path[0] != '\0' )
> avoiding the reindent?

That would leak pty_path.  I could move free(pty_path) out of the if,
though.  I think that would be better.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel