Re: [Xen-devel] [PATCH 1/3] bridge: preserve random init MAC address

[Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>]

On Wed, 12 Mar 2014 20:15:25 -0700
"Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx> wrote:

> As it is now if you add create a bridge it gets started
> with a random MAC address and if you then add a net_device
> as a slave but later kick it out you end up with a zero
> MAC address. Instead preserve the original random MAC
> address and use it.

What is supposed to happen is that the recalculate chooses
the lowest MAC address of the slaves. If there are no slaves
it might as well just calculate a new random value. There is
not great merit in preserving the original defunct address.

Or something like this that just keeps the old value.
The bridge is in a meaningless state when there are no ports,
and when the first port is added back it will be used as the
new bridge id.

--- a/net/bridge/br_stp_if.c    2014-02-12 08:21:56.733857356 -0800
+++ b/net/bridge/br_stp_if.c    2014-03-18 20:09:09.334388826 -0700
@@ -235,6 +235,9 @@ bool br_stp_recalculate_bridge_id(struct
                        addr = p->dev->dev_addr;
 
        }
+
+       if (addr == br_mac_zero)
+               return false;  /* keep original address */
 
        if (ether_addr_equal(br->bridge_id.addr, addr))
                return false;   /* no change */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel