[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 4/7] xen: rename dom0 to hardware_domain
>>> On 18.03.14 at 22:34, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote: > This should not change any functionality other than renaming the global > variable. In a few cases (primarily the domain building code), a local > variable named dom0 was created and used instead of the global to > clarify that the domain being used in this case is actually domain 0. > > Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> > Cc: Ian Campbell <ian.campbell@xxxxxxxxxx> > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx> > Cc: Tim Deegan <tim@xxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> with one minor remark below. > --- a/xen/common/domain.c > +++ b/xen/common/domain.c > @@ -59,7 +59,7 @@ DEFINE_RCU_READ_LOCK(domlist_read_lock); > static struct domain *domain_hash[DOMAIN_HASH_SIZE]; > struct domain *domain_list; > > -struct domain *dom0; > +struct domain *hardware_domain; I already saw that you do so in patch 6, but I think it would be more logical to make this __read_mostly here right away rather than later touching the same line again. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |