[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: handle TapdiskException when add device failed



Wei Liu writes ("Re: [Xen-devel] [PATCH] xen: handle TapdiskException when add 
device failed"):
> On Thu, Mar 20, 2014 at 06:36:54PM +0800, æä wrote:
> > handle the TapdiskException when add device
> > and check the args when using xm block-attach
...
> > +    if not os.path.exists(back_dev):
> > +        print "Error: %s not exist " % back_dev
> > +        sys.exit(1)

I worry that this will break something and that we don't really
understand when tapdisk things are paths and when they might be
something else (iscsi target strings perhaps?)

I think at this stage in xm/xend's life I don't want to change this.

The exception handling part is probably OK...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.