[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH OSSTEST v2 2/4] import enable-xen-config from xen.git, use for ts-kernel-build



Ian Campbell writes ("[PATCH OSSTEST v2 2/4] import enable-xen-config from 
xen.git, use for ts-kernel-build"):
> I plan to remove it from xen.git. Take the version from a03984e7bcdf which
> hasn't changed since 8dedf6431393 in 2010.
> 
> Update ts-kernel-build to not require xen.git.
> 
> config_intree_buildconfigs was unused so remove it.

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Although:

> +    
> target_putfilecontents_stash($ho,1000,enable_xen_config(),"$builddir/enable-xen-config");

Firstly, that line could do with wrapping, and secondly, do you really
expect this to take 1ks ?  100s seems more like it ...

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.