[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v2] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
- To: Thomas Graf <tgraf@xxxxxxxxxx>, Jesse Gross <jesse@xxxxxxxxxx>, <pshelar@xxxxxxxxxx>, <dev@xxxxxxxxxxxxxxx>
- From: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
- Date: Thu, 20 Mar 2014 16:01:59 +0000
- Cc: netfilter@xxxxxxxxxxxxxxx, Miklos Szeredi <mszeredi@xxxxxxx>, kvm@xxxxxxxxxxxxxxx, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Tom Herbert <therbert@xxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Florian Westphal <fw@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Daniel Borkmann <dborkman@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, Joe Perches <joe@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
- Delivery-date: Thu, 20 Mar 2014 16:02:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 20/03/14 12:33, Thomas Graf wrote:
On 03/20/2014 01:16 PM, Thomas Graf wrote:
On 03/19/2014 10:07 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it
doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care
of that
as well.
Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
Acked-by: Thomas Graf <tgraf@xxxxxxxxxx>
I take this back ;)
---
+ if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
+ skb_tx_error(to);
+ return -ENOMEM;
+ }
Just noticed that you orphan the Netlink skb frags which do not
exist yet instead of the source skb frags.
Oh, sorry, I'll fix this up.
Did you consider calling skb_tx_error() for Netlink message
allocation failures for the upcall as well? That memory pressure
is currently not reported back.
Yeah, that makes sense, I'll fix it the callers. Btw. I guess that just
provides some statistical data for the creator of the skb. At least for
netback it only increment a stat counter.
Zoli
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
