[Xen-devel] [PATCH] tools: fix --enable-xenapi typo error

["Yixun Lan (dlan)" <dennis.yxun@xxxxxxxxx>]

typo in tools/configure.ac cause --enable-xenapi does not works
lead to variables XML2_CONFIG, CURL_CONFIG not set

Signed-off-by: Yixun Lan (dlan) <dennis.yxun@xxxxxxxxx>

---

x86_64-pc-linux-gnu-gcc    -L../common/ -shared -o fsimage.so ext2fs-lib.opic 
-lfsimage -lext2fs
make[4]: Leaving directory 
'/var/tmp/portage/app-emulation/xen-tools-4.4.0/work/xen-4.4.0/tools/libfsimage/ext2fs-lib'
make[3]: Leaving directory 
'/var/tmp/portage/app-emulation/xen-tools-4.4.0/work/xen-4.4.0/tools/libfsimage'
make[2]: Leaving directory 
'/var/tmp/portage/app-emulation/xen-tools-4.4.0/work/xen-4.4.0/tools/libfsimage'
make[1]: Leaving directory 
'/var/tmp/portage/app-emulation/xen-tools-4.4.0/work/xen-4.4.0/tools'
make[1]: Entering directory 
'/var/tmp/portage/app-emulation/xen-tools-4.4.0/work/xen-4.4.0/tools'
make -C libxen all
make[2]: Entering directory 
'/var/tmp/portage/app-emulation/xen-tools-4.4.0/work/xen-4.4.0/tools/libxen'
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF
.src@xxxxxxxxxxxxxxxxxxxxxxxxx -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-fno-optimize-sibling-calls  -Iinclude   -fPIC  -c -o
src/xen_string_string_map.o src/xen_string_string_map.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF
.src@xxxxxxxxxxxxxxxx -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-fno-optimize-sibling-calls  -Iinclude   -fPIC  -c -o
src/xen_vbd_mode.o src/xen_vbd_mode.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF
.src@xxxxxxxxxxxxxxxx -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-fno-optimize-sibling-calls  -Iinclude   -fPIC  -c -o
src/xen_vbd_type.o src/xen_vbd_type.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .src@xxxxxxxxxxx
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  
-Iinclude   -fPIC  -c -o src/xen_vdi.o src/xen_vdi.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .src@xxxxxxxxxxx
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  
-Iinclude   -fPIC  -c -o src/xen_pif.o src/xen_pif.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF
.src@xxxxxxxxxxxxxxxx -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-fno-optimize-sibling-calls  -Iinclude   -fPIC  -c -o
src/xen_vdi_type.o src/xen_vdi_type.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF
.src@xxxxxxxxxxxxxxxxxxxxxx -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-fno-optimize-sibling-calls  -Iinclude   -fPIC  -c -o
src/xen_on_normal_exit.o src/xen_on_normal_exit.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .src@xxxxxxxxxxx
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  
-Iinclude   -fPIC  -c -o src/xen_vbd.o src/xen_vbd.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .src@xxxxxxxxxxx
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  
-Iinclude   -fPIC  -c -o src/xen_vif.o src/xen_vif.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .src@xxxxxxxxxxxx
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  
-Iinclude   -fPIC  -c -o src/xen_user.o src/xen_user.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF
.src@xxxxxxxxxxxxxxxxxxx -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-fno-optimize-sibling-calls  -Iinclude   -fPIC  -c -o
src/xen_int_int_map.o src/xen_int_int_map.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF .src@xxxxxxxxxxxxxx
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -fno-optimize-sibling-calls  
-Iinclude   -fPIC  -c -o src/xen_common.o src/xen_common.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
x86_64-pc-linux-gnu-gcc  -O1 -fno-omit-frame-pointer -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes
-Wdeclaration-after-statement -Wno-unused-but-set-variable 
-Wno-unused-local-typedefs   -D__XEN_TOOLS__ -MMD -MF
.src@xxxxxxxxxxxxxxxxxx -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE 
-fno-optimize-sibling-calls  -Iinclude   -fPIC  -c -o
src/xen_string_set.o src/xen_string_set.c
make[2]: --cflags: Command not found
make[2]: --cflags: Command not found
src/xen_common.c:28:27: fatal error: libxml/parser.h: No such file or directory
 #include <libxml/parser.h>
                           ^
compilation terminated.
---
 tools/configure       | 2 +-
 tools/configure.ac    | 2 +-
 tools/libxen/Makefile | 7 +++++--
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/tools/configure b/tools/configure
index e974c5d..5c2fa14 100755
--- a/tools/configure
+++ b/tools/configure
@@ -4702,7 +4702,7 @@ if test x"${PERL}" = x"no"
 then
     as_fn_error $? "Unable to find perl, please install perl" "$LINENO" 5
 fi
-if test "x$xapi" = "xy"; then :
+if test "x$xenapi" = "xy"; then :
 
     # Extract the first word of "curl-config", so it can be a program name 
with args.
 set dummy curl-config; ac_word=$2
diff --git a/tools/configure.ac b/tools/configure.ac
index 884d63d..a62faf8 100644
--- a/tools/configure.ac
+++ b/tools/configure.ac
@@ -151,7 +151,7 @@ AC_PROG_INSTALL
 AC_PATH_PROG([BISON], [bison])
 AC_PATH_PROG([FLEX], [flex])
 AX_PATH_PROG_OR_FAIL([PERL], [perl])
-AS_IF([test "x$xapi" = "xy"], [
+AS_IF([test "x$xenapi" = "xy"], [
     AX_PATH_PROG_OR_FAIL([CURL], [curl-config])
     AX_PATH_PROG_OR_FAIL([XML], [xml2-config])
 ])
diff --git a/tools/libxen/Makefile b/tools/libxen/Makefile
index b66f0bc..262412d 100644
--- a/tools/libxen/Makefile
+++ b/tools/libxen/Makefile
@@ -22,12 +22,15 @@ MAJOR = 1.0
 MINOR = 0
 
 CFLAGS += -Iinclude                     \
-          $(shell $(XML2_CONFIG) --cflags) \
-          $(shell $(CURL_CONFIG) --cflags) \
           -fPIC
 
+ifeq ($(LIBXENAPI_BINDINGS),y)
+CFLAGS += $(shell $(XML2_CONFIG) --cflags) \
+          $(shell $(CURL_CONFIG) --cflags)
+
 LDFLAGS += $(shell $(XML2_CONFIG) --libs) \
            $(shell $(CURL_CONFIG) --libs)
+endif
 
 LIBXENAPI_HDRS = $(wildcard include/xen/api/*.h) include/xen/api/xen_all.h
 LIBXENAPI_OBJS = $(patsubst %.c, %.o, $(wildcard src/*.c))
-- 
1.8.5.2


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel