[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] xen/arm: Move p2m context save/restore in a separate function



On Thu, 2014-03-20 at 17:59 +0000, Julien Grall wrote:

> > Are all of these isb()s necessary?  I guess this is only code motion,
> > so in any case, Acked-by: Tim Deegan <tim@xxxxxxx> (for the whole series)
> > but it seems like at least the one after the VTTBR write could go?
> 
> Thanks for the review.
> 
> Yes, the isb() right after VTBBR can be removed.

Actually I think there are probably loads of barriers in the context
switch path which can be dropped in favour of a final one at the end,
not all that much stuff there relies on stuff which is reloaded before
it (of course we should keep barriers for cases where there is a
dependence).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.