[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

On 03/21/2014 11:31 AM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care of that
as well, and modify the callers accordingly. skb_tx_error() is also added to
the callers so they will signal the failed delivery towards the creator of the

Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
v2: orphan the frags right before touching the frags

- orphan 'from' instead of 'to'
- call skb_tx_error() in the callers if something went wrong

v4: correctly use error path in queue_userspace_packet

LGTM now

Acked-by: Thomas Graf <tgraf@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.