Re: [Xen-devel] [PATCH v2] xen/serial: Don't leak memory mapping if the serial initialization has failed

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-02-19 at 18:07 +0000, Julien Grall wrote:
> The memory mapping is leaking when the serial driver failed to retrieve

"leaked"

> the IRQ. We can safely move the call to ioremap after.
> 
> Also use ioremap_cache instead of ioremap_attr in some serial drivers.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> ---
> 
> Ian, I have dropped your ack because the patch fundamentaly changed.

Apart from the grammar nit you can reinstate it now, I've rereviewed.

You didn't CC Keir BTW.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel