[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] tools/libxl: libxl_get_scheduler should return an int

On 03/21/2014 03:02 PM, Ian Jackson wrote:
> Julien Grall writes ("Re: [PATCH v2] tools/libxl: libxl_get_scheduler should 
> return an int"):
>> On 03/21/2014 02:28 PM, Ian Jackson wrote:
>>> But then I don't understand why you changed this too.  Either of these
>>> changes would suffice by itself, and the former is marginally less
>>> fiddly.
>> The variable sched is a libxl_scheduler in this function. I can't modify
>> the type because it's used with lixbl_scheduler_from_string (see
>> xl_cmdimpl.c:6703).
> Ah.  I think libxl_scheduler_from_string should be changed too.

libxl_scheduler_from_string is similar to all libxl*_from_string enum
function. If we change this function we should also modify
libxl_bios_type_from_string, libxl_timer_mode_from_string...


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.