Re: [Xen-devel] [PATCH v2 1/7] xenstore-read: add support for a retry open limit on xenstored

["Luis R. Rodriguez" <mcgrof@xxxxxxxx>]

On Fri, Mar 21, 2014 at 03:40:05PM +0000, David Vrabel wrote:
> On 19/03/14 20:58, Luis R. Rodriguez wrote:
> > From: "Luis R. Rodriguez" <mcgrof@xxxxxxxx>
> > 
> > This adds support for a customizable retry limit on trying to open
> > the xenstored, each retry is separated by 1 second. This should allow
> > us to simplify both our LSB init scripts and eventually our systemd
> > service files for starting the xenstored.
> 
> 
> This seems odd. Surely the point of systemd is that you only start
> services once their dependencies are up?  It doesn't seem right to have
> a service poll for another.

I was unable to verify the dogs will be let loose only once a service
which claims a socket is available, so I left the check for now but
I think once we do confirm this we should remove it. This retry is
also useful for the old LSB scripts though too, it just shaves off
of the existing shell script.

> > diff --git a/tools/xenstore/xenstore_client.c 
> > b/tools/xenstore/xenstore_client.c
> > index 0ec103f..87972b7 100644
> > --- a/tools/xenstore/xenstore_client.c
> > +++ b/tools/xenstore/xenstore_client.c
> > @@ -77,7 +77,8 @@ usage(enum mode mode, int incl_mode, const char *progname)
> >     errx(1, "Usage: %s <mode> [-h] [...]", progname);
> >      case MODE_read:
> >     mstr = incl_mode ? "read " : "";
> > -   errx(1, "Usage: %s %s[-h] [-p] [-s] key [...]", progname, mstr);
> > +   errx(1, "Usage: %s %s[-h] [-p] [-s] [ -l <num_open_tries> ] key [...]",
> > +        progname, mstr);
> 
> The command line option would be better as a time out value (in seconds).

-t for "tidy" is taken, let me know what you guys decide for preference.

  Luis

Attachment: pgp0SkgGlfczC.pgp
Description: PGP signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel