Re: [Xen-devel] [PATCH v3 7/7] systemd: add support initial xen systemd service files

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2014-03-22 at 03:30 +0100, Luis R. Rodriguez wrote:
> On Fri, Mar 21, 2014 at 03:40:50PM +0000, Ian Campbell wrote:
> > On Wed, 2014-03-19 at 14:07 -0700, Luis R. Rodriguez wrote:
> > > As for integration with xen, we house keep all the systemd files
> > > under a new directory tools/hotplug/Linux/systemd/ and will be
> > > targetted
> > > by default when building on Linux systems (CONFIG_Linux) given the low
> > > overhead of only having to only sed the meta @VARIABLES@.
> > 
> > Could configure not generate these more easily than what you have below?
> 
> Not sure, I've dodged configure all my life.
> 
> > It could still be conditional on Linux I'd have though, given a little
> > bit of autofoo ninjutsu.
> 
> I'm autofoo dumb.

For this case I think you just need to add the files to
tools/configure.ac:AC_CONFIG_FILES

> > > +%.socket: %.socket.in
> > > +       cp $< $@
> > > +       @sed -i -e 's|\@SBINDIR\@|$(SBINDIR)|g'                $@
> > > +       @sed -i -e 's|\@BINDIR\@|$(BINDIR)|g'                  $@
> > > +       @sed -i -e 's|\@XEN_RUN_DIR\@|$(XEN_RUN_DIR)|g'        $@
> > > +       @sed -i -e 's|\@XEN_LOG_DIR\@|$(XEN_LOG_DIR)|g'        $@
> > > +       @sed -i -e 's|\@XEN_LIB_STORED\@|$(XEN_LIB_STORED)|g'  $@
> > > +       @sed -i -e 's|\@LIBEXEC\@|$(LIBEXEC)|g'                $@
> > > +
> > > +%.service: %.service.in
> > > +       cp $< $@
> > > +       @sed -i -e 's|\@SBINDIR\@|$(SBINDIR)|g'                $@
> > > +       @sed -i -e 's|\@BINDIR\@|$(BINDIR)|g'                  $@
> > > +       @sed -i -e 's|\@XEN_RUN_DIR\@|$(XEN_RUN_DIR)|g'        $@
> > > +       @sed -i -e 's|\@XEN_LOG_DIR\@|$(XEN_LOG_DIR)|g'        $@
> > > +       @sed -i -e 's|\@XEN_LIB_STORED\@|$(XEN_LIB_STORED)|g'  $@
> > > +       @sed -i -e 's|\@LIBEXEC\@|$(LIBEXEC)|g'                $@
> > > +
> > > +%.mount: %.mount.in
> > > +       cp $< $@
> > > +       @sed -i -e 's|\@SBINDIR\@|$(SBINDIR)|g'                $@
> > > +       @sed -i -e 's|\@BINDIR\@|$(BINDIR)|g'                  $@
> > > +       @sed -i -e 's|\@XEN_RUN_DIR\@|$(XEN_RUN_DIR)|g'        $@
> > > +       @sed -i -e 's|\@XEN_LOG_DIR\@|$(XEN_LOG_DIR)|g'        $@
> > > +       @sed -i -e 's|\@XEN_LIB_STORED\@|$(XEN_LIB_STORED)|g'  $@
> > > +       @sed -i -e 's|\@LIBEXEC\@|$(LIBEXEC)|g'                $@ 
> > 
> > If you do keep this then itis crying out for a helper macro/make
> > function.
> 
> Can we welcome this as an enhancement?

If not the autoconf way then I'd like to at least see this collapsed
into one instance with some make facitily or other please.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel