Re: [Xen-devel] [RFC PATCH v1 06/10] xen/arm: split gic driver into generic and gicv2 driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2014-03-23 at 14:43 +0000, Julien Grall wrote:
> Hello Vijay,
> 
> On 22/03/14 09:32, Vijay Kilari wrote:
> > On Thu, Mar 20, 2014 at 5:25 PM, Stefano Stabellini
> > <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> >> On Wed, 19 Mar 2014, vijay.kilari@xxxxxxxxx wrote:
> >>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> >>>
> >>> Existing GIC driver has both generic code and hw specific
> >>> code. Segregate GIC low level driver into gic-v2.c and
> >>> keep generic code in existing gic.c file
> >>>
> >>> GIC v2 driver registers required functions
> >>> to generic GIC driver. This helps to plug in next version
> >>> of GIC drivers like GIC v3.
> >>>
> >>> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> >>
> >> Am I correct in assuming that this patch is just code movement plus the
> >> introduction of struct gic_hw_operations?
> >>
> > Yes, as a part of code movement, I introduced this structure and
> > used this callbacks in generic code
> 
>  From what I saw, this patch is not only code movement. You are 
> modifying/removing some functions without any explanation (see SGI stuffs).
> 
> I would prefer if you modify theses on another patch. So this patch will 
> only be code movement.

Yes, please.

One plausible sequence of patches might be:
- Add struct gic_hw_operations for v2 stuff all in the same file
- Move the v2 stuff out into the new file (pure motion)
- Other changes/cleanups
- Add the v3 stuff

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel