Re: [Xen-devel] [PATCH v7 3/3] x86/hvm: Indicate avaliability of HW support of APIC virtualization to HVM guests

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.03.14 at 00:18, <boris.ostrovsky@xxxxxxxxxx> wrote:
> +void vmx_hypervisor_cpuid_leaf(uint32_t sub_idx,
> +                               uint32_t *eax, uint32_t *ebx,
> +                               uint32_t *ecx, uint32_t *edx)
> +{
> +    if ( sub_idx != 0 )
> +        return;
> +
> +    if ( cpu_has_vmx_apic_reg_virt )
> +        *eax |= XEN_HVM_CPUID_APIC_ACCESS_VIRT;
> +    if ( cpu_has_vmx_virtualize_x2apic_mode )
> +        *eax |= XEN_HVM_CPUID_X2APIC_VIRT;
> +}

So did the two of you then settle on (a) needing to expose two bits
rather than just one and (b) these being the two relevant features
to expose?

Jan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel