Re: [Xen-devel] [PATCH v4 3/7] arch, arm: let map_mmio_regions() take pfn as parameters

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Stefano and Arianna,

On 03/25/2014 12:22 PM, Stefano Stabellini wrote:
>> -    return apply_p2m_changes(d, INSERT, start_gaddr, end_gaddr,
>> -                             maddr, MATTR_DEV, p2m_mmio_direct);
>> +    return apply_p2m_changes(d, INSERT,
>> +                             pfn_to_paddr(start_gfn),
>> +                             pfn_to_paddr(end_gfn),
>> +                             pfn_to_paddr(mfn),
>> +                             MATTR_DEV, p2m_mmio_direct);
>>  }
> 
> This doesn't make any sense. Shouldn't you modify apply_p2m_changes to
> take pfns as parameters too?

If so, I think it should be a separate patch. Her change makes sense
with the current interface.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel