Re: [Xen-devel] [PATCH 23/34] xen/sched: credit2: Some functions are only used internally

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 03/25/2014 04:55 PM, Julien Grall wrote:
> The list of function above are only used internally in common/domctl.c
>      - migrate
>      - update_max_weight
>
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

> ---
>   xen/common/sched_credit2.c |   11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
> index 6729564..97f4049 100644
> --- a/xen/common/sched_credit2.c
> +++ b/xen/common/sched_credit2.c
> @@ -696,7 +696,8 @@ void burn_credits(struct csched_runqueue_data *rqd, struct 
> csched_vcpu *svc, s_t
>   }
>
>   /* Find the domain with the highest weight. */
> -void update_max_weight(struct csched_runqueue_data *rqd, int new_weight, int 
> old_weight)
> +static void update_max_weight(struct csched_runqueue_data *rqd, int new_weight,
> +                              int old_weight)
>   {
>       /* Try to avoid brute-force search:
>        * - If new_weight is larger, max_weigth <- new_weight
> @@ -1182,10 +1183,10 @@ static void consider(balance_state_t *st,
>   }
>
>
> -void migrate(const struct scheduler *ops,
> -             struct csched_vcpu *svc,
> -             struct csched_runqueue_data *trqd,
> -             s_time_t now)
> +static void migrate(const struct scheduler *ops,
> +                    struct csched_vcpu *svc,
> +                    struct csched_runqueue_data *trqd,
> +                    s_time_t now)
>   {
>       if ( test_bit(__CSFLAG_scheduled, &svc->flags) )
>       {

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel