Re: [Xen-devel] [PATCH v4 2/7] arch, arm: add consistency checks to REMOVE p2m changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Tue, 2014-03-25 at 03:02 +0100, Arianna Avanzini wrote:
> -    paddr_t addr;
> +    paddr_t addr, _maddr;

I'm afraid that the _ namespace is reserved, so this is not an
acceptable name for this variable. (I thought I said this before, but my
email archive says not, sorry).

Why can the existing maddr not be used, which might involve incrementing
it in some more cases, in fact I think the increment in the INSERT case
could be pulled out to the same place as the increment of addr without
causing any harm.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel