[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 00/34] Add clang support for ARM and cleanups

Hi Stefano,

On 25/03/14 18:22, Stefano Stabellini wrote:
On Tue, 25 Mar 2014, Julien Grall wrote:
Hello all,

The main goal of this patch series is to add support for Clang on ARM.
The work has been done with Clang 3.5 which is not yet release but have
a good support for ARM32. I think clang 3.4 may also be able to compile
Xen but I didn't try.

With the first part of the serie (patch #1-#19 and patch #33), I'm able to boot
Xen compiled by Clang on midway. The patch #33 workaround for a bug in Clang
(http://llvm.org/bugs/show_bug.cgi?id=19199). I'm not sure if the patch would
be acceptable for Xen upstream.

While I was working on Clang 3.5, I played with -Wmissing-prototypes (patch 
and discovered some exported functions which were:
     - the prototype were not declared before because of a missing include
     - never used

Finally the last part of this series (patch #31-33) contains a start of
bug fixes to be able to compile the tools with Clang. I didn't include
the patch https://patches.linaro.org/26826/.

The branch will all the patch applied (+few required patches) can be found here:
     git clone git://xenbits.xen.org/people/julieng/xen-unstable.git -b clang

Any comments and questions are welcomed.

Patches #5 #7 #8 #9 #10 #12 #16 #17 #18 #20 #21 #22 #23 #24 #25 #26 #28
#29 are correct and I think they should be applied.
You can add my reviewed-by to them.

Thanks for your review. FYI, every patches can be applied separately.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.