[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH v1 03/10] xen/arm: move vgic data to vgic driver

On Wed, Mar 26, 2014 at 5:30 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Wed, 2014-03-26 at 17:14 +0530, Vijay Kilari wrote:
>> > If that is the case then I don't think there is any reason to split this
>> > struct into v2 and v3 versions. Just keep a single struct with the
>> > larger itargets using v3 semantics and have the v2 driver do the obvious
>> > packing and unpacking.
>> >
>>   The complete vgic driver is based on this structure and with change in size
>> and number of registers for itargets register is not clean enough to manage
>> single vgic driver for both v2 & v3.
> What does "not clean enough" mean?

   I mean for v2 the itargets is uint32_t itargets[8] where each
interrupt routing
information is specified with 8 bits and hence 8 32-bit registers can
handle 32 IRQs.

   Where as in v3, itargets is uint64_t itargets[32] where each
interrupt routing
information is specified with 64 bits and hence 32 64-bit registers
are required to handle
32 IRQ's.

  I will make it common structure by putting this itargets under union.

> BTW I was suggesting a common datastructure, not a single driver.
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.