Re: [Xen-devel] [PATCH v3 4/5] xen: Define EFI related stuff

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.03.14 at 21:57, <daniel.kiper@xxxxxxxxxx> wrote:
> Define EFI related stuff for Xen.
> 
> This patch is based on Jan Beulich and Tang Liang work.

And with this, ...

> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> Signed-off-by: Tang Liang <liang.tang@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

... these should be in the reverse order to reflect flow.

> +struct xenpf_efi_runtime_call {
> +     uint32_t function;
> +    /*
> +     * This field is generally used for per sub-function flags (defined
> +     * below), except for the XEN_EFI_get_next_high_monotonic_count case,
> +     * where it holds the single returned value.
> +     */
> +     uint32_t misc;
> +     unsigned long status;
> +     union {

You surely would want to use consistent indentation here (i.e. a leading
hard tab)?

> @@ -143,7 +245,25 @@ struct xenpf_firmware_info {
>                       /* must refer to 128-byte buffer */
>                       GUEST_HANDLE(uchar) edid;
>               } vbeddc_info; /* XEN_FW_VBEDDC_INFO */
> -

Please retain blank lines like this ...

> +             union xenpf_efi_info {
> +                     uint32_t version;
> +                     struct {
> +                             uint64_t addr;   /* EFI_CONFIGURATION_TABLE */
> +                             uint32_t nent;
> +                     } cfg;
> +                     struct {
> +                             uint32_t revision;
> +                             uint32_t bufsz;  /* input, in bytes */
> +                             GUEST_HANDLE(void) name;
> +                             /* UCS-2/UTF-16 string */
> +                             } vendor;
> +                     struct {
> +                             uint64_t addr;
> +                             uint64_t size;
> +                             uint64_t attr;
> +                             uint32_t type;
> +                             } mem;
> +             } efi_info; /* XEN_FW_EFI_INFO */

... and add one here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel