Re: [Xen-devel] [PATCH] xen/x86: Identify which vcpu's CR4 is being badly modified

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.03.14 at 14:30, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 26/03/14 13:17, Jan Beulich wrote:
>>>>> On 25.03.14 at 20:40, <andrew.cooper3@xxxxxxxxxx> wrote:
>>> When the toolstack is setting vcpu state on behalf of a migrating guest, the
>>> domain/vcpu reference from gdprintk() identifies the toolstack, not the
>>> affected domain.
>>>
>>> After this change, the error looks more like:
>>>
>>>   domain.c:632:d0v3 Attempt to change d1v0's CR4 flags 00002660 -> 01875000
>> And is the leading d0v3 really useful here in any way? I'd really like to
>> see unmotivated uses of gdprintk() replaced by printk(XENLOG_G_...).
>>
>> Jan
> 
> Personally, I find it useful to distinguish between "the toolstack tried
> something" and "a guest tried something", although the file/line
> reference is quite useless.
> 
> Perhaps printk(XENLOG_G_WARNING "%pv attempted to change %pv's CR4 flags
> ...", current, v ....) ?

Which vCPU this was being done on is of no interest at all; I can see
the originating domain being useful to know.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel