Re: [Xen-devel] Possible memory leak in qemu-dm (qemu-dm swapping 20GB+, adding 2gb+ per day)

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Wed, Mar 26, 2014 at 09:41:34AM +0000, Ian Campbell wrote:
> On Wed, 2014-03-26 at 20:09 +1100, Steven Haigh wrote:
> > On 26/03/14 19:57, Ian Campbell wrote:
> > > On Wed, 2014-03-26 at 16:23 +1100, Steven Haigh wrote:
> > >> Valgrind log available here:
> > >> http://xen.crc.id.au/bugs/view.php?id=25
> > > 
> > > Thanks.
> > > 
> > > Before we go any further, can you confirm that you have this commit in
> > > your qemu-xen-traditional tree:
> > >         commit 96b58a44756a8821c108358439b0f2c06e531159
> > >         Author: Matthew Daley <mattd@xxxxxxxxxxx>
> > >         Date:   Wed Dec 4 15:16:18 2013 +1300
> > >         
> > >             xen_disk: fix memory leak
> > >             
> > >             On ioreq_release the full ioreq was memset to 0, losing all 
> > > the data
> > >             and memory allocations inside the QEMUIOVector, which leads 
> > > to a
> > >             memory leak. Create a new function to specifically reset 
> > > ioreq.
> > >             
> > >             Reported-by: Maik Wessler <maik.wessler@xxxxxxxxx>
> > >             Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > >             Signed-off-by: Stefano Stabellini 
> > > <stefano.stabellini@xxxxxxxxxxxxx>
> > >             
> > >             Backport to qemu-xen-traditional.
> > >             
> > >             Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>
> > >             Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > >         
> > >> Do you have any further suggestions / ideas based on this?
> > > 
> > > Unfortunately the qemu-dm binary seems to have been stripped, which
> > > removes much of the useful info from the traces. Please can you make
> > > sure you have the following commit to the qemu-xen-traditional tree:
> > >         commit 18a08a23da88863435d56a0b14ff72013ef3b003
> > >         Author: Olaf Hering <olaf@xxxxxxxxx>
> > >         Date:   Tue Oct 15 11:42:26 2013 +0200
> > >         
> > >             qemu-traditional: do not strip binaries during make install
> > >             
> > >             It is wrong to strip code during make install, unless explicit
> > >             requested. Introduce a new variable INSTALL_PROG and use it 
> > > along with
> > >             an optional STRIP_OPT where currently install -s -m 755 is 
> > > used.
> > >             This is what upstream qemu offers in version 1.6.
> > >             
> > >             Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> > >         
> > 
> > I am using the qemu-xen-traditional that comes with xen-4.2.3.tar.gz
> 
> And have you confirmed that this does or does not contain the above fix?
> 

http://xenbits.xen.org/gitweb/?p=qemu-xen-4.2-testing.git;a=summary

So qemu-traditional in Xen 4.2.3 does NOT have the fix.
The fix is included in Xen 4.2.4.

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel