[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] x86/HVM: fix preemption handling in do_hvm_op()

>>> On 26.03.14 at 15:42, <George.Dunlap@xxxxxxxxxxxxx> wrote:
> Is there a real problem with "altering [interface structures] in a way
> the caller may not expect"?  Can't we just document that Xen may
> change some of the structures?

The two main problems here, just like with the memory op we had to
change before 4.4, are
- we can't and shouldn't assume that qemu is the only consumer, and
  hence surprises to the caller must be avoided
- no interface anywhere in the tree should set bad precedents, or
  else keeping people from doing the same wrong thing elsewhere is
  much harder to achieve (i.e. just like in so many other places
  recently, I'm advocating for consistency throughout the source
  base here)


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.