Re: [Xen-devel] [PATCH 05/34] xen/xsm: flask: Remove unused function avc_sidcmp

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 03/26/2014 11:57 AM, Jan Beulich wrote:
>>>> On 25.03.14 at 17:55, <julien.grall@xxxxxxxxxx> wrote:
>> Fix compilation with Clang 3.5:
>>
>> avc.c:657:19: error: unused function 'avc_sidcmp' [-Werror,-Wunused-function]
>> static inline int avc_sidcmp(u32 x, u32 y)
> 
> Despite Daniel having acked this already, this seems conceptually wrong
> to me: static inline functions are quite frequently unused (and I assume
> the compiler warns about them only if they're not in a header file), and
> hence the compiler shouldn't be warning about them in the first place.

This function has not been used seen 2007. I think this is the only
static inline function not defined in headers which is not used.

Why shouldn't the compiler warn about it? Rather than static inline
function defined in the header, this kind function is dead code. If we
want to keep it we should at least mark them as unused.

IHMO I don't think we need to keep function that weren't used since ages
and I bet it was a forgotten when the code was reworked a long time ago.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel