Re: [Xen-devel] [PATCH 19/34] xen/arm: Provide eabi wrapper for __aeabi_mem* functions

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 03/26/2014 04:46 PM, Tim Deegan wrote:
> At 16:39 +0000 on 26 Mar (1395848341), Julien Grall wrote:
>> On 03/26/2014 04:22 PM, Tim Deegan wrote:
>>> At 16:11 +0000 on 26 Mar (1395846677), Ian Campbell wrote:
>>
>>>> The correct wording for the commit message would therefore be something
>>>> like "Provide __aeabi_memset et al which are required by EABI and which
>>>> compilers expect to be provided by the libc implementation", or
>>>> something like that.
>>>
>>> +1.  AFAICT these are in the same class as functions like
>>> __aeabi_idiv(), (which we already supply in /arm/arm32/lib/*.S), and
>>> should be handled the same way.
>>
>> I didn't see any issues with an __aebi_*div* function. Shall we wait
>> until a failure?
> 
> What I was trying to say is: we already supply the __aebi_*div*
> functions, so adding the __aeabi_memset ones is correct.

Sorry I misunderstood your previous comment.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel