[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 30/34] xen: Add missing includes on different files

On 03/26/2014 12:57 PM, Jan Beulich wrote:
>>>> On 25.03.14 at 17:55, <julien.grall@xxxxxxxxxx> wrote:
>> --- a/xen/common/multicall.c
>> +++ b/xen/common/multicall.c
>> @@ -6,6 +6,9 @@
>>  #include <xen/types.h>
>>  #include <xen/lib.h>
>>  #include <xen/mm.h>
>> +#ifndef COMPAT
>> +#include <xen/hypercall.h>
>> +#endif
> Is there anything wrong with adding this without the seemingly
> unmotivated #ifndef?

The prototype in hypercall.h return directly long, but the definition
returns ret_t (which is replaced by int if COMPAT is defined).

This will result to a compilation failure:

In file included from multicall.c:41:0:
../multicall.c:38:1: error: conflicting types for ‘compat_multicall’
In file included from ../multicall.c:9:0,
                 from multicall.c:41:

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.