Re: [Xen-devel] [RFC PATCH v1 02/10] xen/arm: register mmio handler at runtime

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Wed, Mar 26, 2014 at 8:17 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> On 03/26/2014 12:29 PM, Vijay Kilari wrote:
>> Hi Julien,
>>
>>
>> On Fri, Mar 21, 2014 at 10:53 PM, Julien Grall <julien.grall@xxxxxxxxxx> 
>> wrote:
>>> On 03/21/2014 05:17 PM, Ian Campbell wrote:
>>>> On Wed, 2014-03-19 at 19:47 +0530, vijay.kilari@xxxxxxxxx wrote:
>>>>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>>>>
>>>>> mmio handlers are registers at compile time
>>>>> for drivers like vuart and vgic.
>>>>> Make mmio handler registered at runtime by
>>>>> creating linked list of mmio handlers
>>>>
>>>> I'm not convinced of the need for this, certainly the vgic side can just
>>>> demux into v2 or v3 as necessary.
>>>
>>> Demux the code just add an indirection. We could have a list of mmio
>>> handler per domain and rely on it to call the right handler. A bit like x86.
>>>
>>  Until Andrii adds IOMMU  handling should keep this patch? and adopt
>> to it later?
>
> I'm not sure to understand. IHMO, it doesn't sound right to upstream a
> patch that we know it will be superseded in a couple of months. Why
> can't you rework your patch to have it in good shape now?
>
 I assume that Andii's patch will be required to make mmio handlers
per domain. If not let me know references in x86 that I can make it
per domain specific mmio handlers.

I was more inclined to go with this patch for now because it helps to
go ahead with GICv3 and anything beyond this can be managed separately.
Please let me know you opinion.

>>   Also vgic & vuart are not per domain specific
>
> The vuart is per domain specific. Only dom0 is using the callback.
>
> Regards,
>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel