Re: [Xen-devel] [PATCH 3/8] x86/EPT: also dump permissions and memory types

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.03.14 at 14:06, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 26/03/14 15:34, Jan Beulich wrote:
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> --- a/xen/arch/x86/mm/p2m-ept.c
>> +++ b/xen/arch/x86/mm/p2m-ept.c
>> @@ -730,6 +730,14 @@ static void ept_dump_p2m_table(unsigned 
>>      unsigned long record_counter = 0;
>>      struct p2m_domain *p2m;
>>      struct ept_data *ept;
>> +    static const char memoryTypes[8][2] = {
>> +        [0 ... 7] = "?",
>> +        [MTRR_TYPE_UNCACHABLE]     = "UC",
>> +        [MTRR_TYPE_WRCOMB]         = "WC",
>> +        [MTRR_TYPE_WRTHROUGH]      = "WT",
>> +        [MTRR_TYPE_WRPROT]         = "WP",
>> +        [MTRR_TYPE_WRBACK]         = "WB",
>> +    };
> 
> Dont we have an identical structure somewhere else in Xen already?

I added a similar one recently, but I decidedly want only two characters
here (these dumps are already unreasonably large).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel