[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 17/34] xen/arm: Guard correctly asm-arm/platform/omap5.h

On Thu, 2014-03-27 at 16:52 +0000, Julien Grall wrote:
> On 03/27/2014 04:44 PM, Ian Campbell wrote:
> > (I think this series would have been more manageable if it had fixed
> > each similar class of error in one patch....)
> Sorry, I usually work with very small patch to understand every changes.

I don't think a single "fix typos in header guard #defines" patch would
have hindered that, but it would have reduced this series to less than
30 patches, which would have been very worthwhile. Likewise for marking
BUILD_BUG_ON functions as always unused in a single patch and making
things static etc.

> I though it was better to send as is it on the ML.

Please try and keep the sanity of people trying to review dozens of
patches a day in mind.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.