[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 32/34] tools/libxl: list_domains: shutdown is typed unsigned
On Tue, 2014-03-25 at 18:22 +0000, Andrew Cooper wrote: > On 25/03/14 16:55, Julien Grall wrote: > > Don't need to check if shutdown is positive. > > > > Fix compilation with clang 3.5: > > xl_cmdimpl.c:3350:34: error: comparison of unsigned expression >= 0 is > > always true [-Werror,-Wtautological-compare] > > (shutdown_reason >= 0 && > > ~~~~~~~~~~~~~~~ ^ ~ > > Coverity-ID: 1055616 > > > Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx> > > Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> > > Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Although that construct looks ripe for refactoring for clarity to me. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |