Re: [Xen-devel] [PATCH 30/34] xen: Add missing includes on different files

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-27 at 17:30 +0000, Julien Grall wrote:
> On 03/27/2014 05:11 PM, Ian Campbell wrote:
> > On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote:
> >> This was spotted by -Wmissing-prototypes, which we can't enable because 
> >> there
> >> is exported function for assembly. I'm not sure if we need to add a 
> >> prototype
> >> for them.
> > 
> > What exactly is the issue here?
> 
> There a bunch of functions (see below for ARM) where the prototype is
> not defined before. Mainly because theses functions are used by the
> assembly code so we don't need to give a prototype.
> 
> do_trap_*
> start_xen
> start_secondary
> leave_hypervisor_tail

Is that all of them? Although their prototypes are useless there are few
enough of them that the benefit of being able to turn on
Wmissing-prototypes might make it worth it.

Unless there is some attribute we can apply which marks these as not
requiring a prototype? Even better if as a side effect the compiler will
warn about calls not from assembly...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel