[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [ARM:PATCH v2 1/1] Pass the timer clock-frequency to DOM0

Hello Suriyan,

(Adding the other Xen ARM maintainers).

Thank you for the patch. Xen-devel starts to have a big traffic, we use to cc maintainers on patches. You can find them via script/get_maintainers.pl

On 27/03/14 03:54, Suriyan Ramasami wrote:
     xen/arm: Pass the timer "clock-frequency" to DOM0 in make_timer_node

You guess you are copying git show in an email? If so, I advise you to read this website:

     If the DT representing the ARM generic timer mentions a clock-frequency,
     propragate it to the DT that is built for DOM0.

     This is necessary as a workaround for boards (Odroid-XU) where CNTFRQ is
     not set or returns a wrong value.

Do you have any plan to send a similar patch for domU?

@@ -639,6 +641,9 @@ static int make_timer_node(const struct domain *d, void 
          return -FDT_ERR_XEN(ENOENT);

+    clock_valid = dt_property_read_u32(dev, "clock-frequency",
+                                       &clock_frequency);

Can you gather all your changes in one place? I don't see why you need to read the clock-frequency earlier.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.