Re: [Xen-devel] [PATCH] arm: xen: implement multicall hypercall support.

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 03/28/2014 02:07 PM, Ian Campbell wrote:
> As part of this make the usual change to xen_ulong_t in place of unsigned 
> long.
> This change has no impact on x86.
> 
> The Linux defintion of struct multicall_entry.result differs from the Xen

definition

[..]

> diff --git a/arch/arm/include/asm/xen/hypercall.h 
> b/arch/arm/include/asm/xen/hypercall.h
> index 7704e28..7658150 100644
> --- a/arch/arm/include/asm/xen/hypercall.h
> +++ b/arch/arm/include/asm/xen/hypercall.h
> @@ -48,6 +48,7 @@ int HYPERVISOR_memory_op(unsigned int cmd, void *arg);
>  int HYPERVISOR_physdev_op(int cmd, void *arg);
>  int HYPERVISOR_vcpu_op(int cmd, int vcpuid, void *extra_args);
>  int HYPERVISOR_tmem_op(void *arg);
> +int HYPERVISOR_multicall(struct multicall_entry *calls, uint32_t nr);

The x86 prototype of HYPERVISOR_multicall takes an int as 2nd parameter.
I guess we should stay consistent here.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel