Re: [Xen-devel] [PATCH v4 4/7] xen, common: add the XEN_DOMCTL_memory_mapping hypercall

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Tue, 2014-04-01 at 16:18 +0100, Jan Beulich wrote:
> >>> On 01.04.14 at 17:01, <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> > Although the reuse of the add variable in the else clause if an if (add)
> > is pretty damned confusing...
> 
> I was really surprised that no-one said this earlier on this thread (and
> yes, I'm guilty in having introduced this in the x86 code, wanting to
> avoid adding another variable).

;-)

I only noticed it because I was about to say "how can this code be
right, we are in the else clause".

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel