Re: [Xen-devel] [PATCH 26/34] xen/arm: traps: Drop dump_guest_s1_walk

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 03/27/2014 05:09 PM, Ian Campbell wrote:
> On Tue, 2014-03-25 at 16:55 +0000, Julien Grall wrote:
>> This function is not used neither export.
> 
> I have used it when debugging stuff, where it is very useful.

I was not sure if anyone was using it. I can export it in p2m.h.

I'm also thinking to move this function in p2m.c (which is a best place
for this function). What do you think?

> Should it not be called from one of the dump_vcpu_state in response to
> an exception which implies a guest translation fault?
> 

No, we inject directly an exception to the guest since few months. So we
don't have to print the p2m.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel