Re: [Xen-devel] [PATCH 2/3] xen: arm: flush TLB on all CPUs when setting or clearing fixmaps

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-02 at 16:22 +0100, Ian Campbell wrote:
> > This loop is exactly the same on arm64 (except the TLBIMVAHIS), is it
> > possible to have a common code like clean_xen_dcache_va_range?
> 
> flush_xen_data_tlb_range_va_local has the same issue. I'll fix them
> both.

Actually there is a second difference which I didn't remember which is 
        : : "r" (va) : "memory");
vs:
     : : "r" (va>>PAGE_SHIFT) : "memory");

That's a lot harder to abstract away conveniently. I could have a
#define for the shift amount, I guess. I'll have a play and see if I can
come up with something satisfactory. If not I'll fall back to keeping
the loops per subarch.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel