[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [libvirt] [PATCH 1/3] libxl: Use id from virDomainObj inside the driver

On 27.03.2014 17:55, Stefan Bader wrote:
There is a domain id in the virDomain structure as well as in the
virDomainObj structure. While the former can become stale the latter
is kept up to date. So it is safer to always (virDomainObjPtr)->def->id

This will fix issues seen when managing Xen guests through libvirt from
virt-manager (not being able to get domain info after define or reboot).
This was caused both though libxlDomainGetInfo() only but there were
a lot of places that might potentially cause issues, too.

Signed-off-by: Stefan Bader <stefan.bader@xxxxxxxxxxxxx>
  src/libxl/libxl_driver.c |   75 +++++++++++++++++++++++-----------------------
  1 file changed, 38 insertions(+), 37 deletions(-)

Oh, you've sent the patch again. This time as a part of bigger set. Anyway, my ACK stands.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.