Re: [Xen-devel] [PATCH v2 15/16] xen: IRQ: Add dev_id parameter to release_irq

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/04/2014 08:47 AM, Jan Beulich wrote:
>>>> On 03.04.14 at 22:42, <julien.grall@xxxxxxxxxx> wrote:
>> --- a/xen/arch/x86/irq.c
>> +++ b/xen/arch/x86/irq.c
>> @@ -983,7 +983,7 @@ int __init request_irq(unsigned int irq,
>>      return retval;
>>  }
>>  
>> -void __init release_irq(unsigned int irq)
>> +void release_irq(unsigned int irq, const void *dev_id)
> 
> Why? There shouldn't be any post-init use for it (and in fact the
> function is - as you validly say - entirely unused right now), so
> there's no need for it to stay in memory.

Oops, my mistake. The x86 version should keep the __init but not ARM. I
will re-add the __init in the next version.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel