Re: [Xen-devel] [PATCH v4 1/8] ioreq-server: pre-series tidy up

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> Sent: 07 April 2014 11:49
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxx; Keir (Xen.org)
> Subject: Re: [PATCH v4 1/8] ioreq-server: pre-series tidy up
> 
> >>> On 02.04.14 at 17:11, <paul.durrant@xxxxxxxxxx> wrote:
> > @@ -485,7 +485,7 @@ static int hvm_set_ioreq_page(
> >
> >      if ( (iorp->va != NULL) || d->is_dying )
> >      {
> > -        destroy_ring_for_helper(&iorp->va, iorp->page);
> > +        destroy_ring_for_helper(&va, page);
> 
> This clearly isn't just tidying: The bug fix should at least be mentioned
> in the description, but for the purposes of backporting it should
> probably be submitted as a separate patch.

Ok. I'll separate it.

> 
> > --- a/xen/arch/x86/hvm/io.c
> > +++ b/xen/arch/x86/hvm/io.c
> > @@ -46,10 +46,9 @@
> >  #include <xen/iocap.h>
> >  #include <public/hvm/ioreq.h>
> >
> > -int hvm_buffered_io_send(ioreq_t *p)
> > +int hvm_buffered_io_send(struct domain *d, const ioreq_t *p)
> >  {
> > -    struct vcpu *v = current;
> > -    struct hvm_ioreq_page *iorp = &v->domain-
> >arch.hvm_domain.buf_ioreq;
> > +    struct hvm_ioreq_page *iorp = &d->arch.hvm_domain.buf_ioreq;
> 
> This isn't a purely cosmetic change either, especially without an
> ASSERT(current->domain == d). It looks to be correct with one minor
> exception: There's a gdprintk() in this function, which - if you don't
> expect the function to be called for the current domain only - needs to
> be altered to not falsely print the current vCPU as subject anymore.
> 

It will only by called for the current domain - I was just making it more 
analogous with hvm_send_assist_req() which takes a vcpu as an argument even 
though, in practice, it's always current. Perhaps I should tidy away that 
argument rather than introducing a new one here.

  Paul

> Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel