Re: [Xen-devel] [PATCH v2 01/15] xen/arm: register mmio handler at runtime

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/08/2014 05:47 AM, Vijay Kilari wrote:
>>>>
>>>>>
>>>>> -const struct mmio_handler vgic_distr_mmio_handler = {
>>>>> +static struct mmio_handler vgic_distr_mmio_handler = {
>>>>
>>>> Why did you remove the const?
>>>
>>> I think, compiler is allowing forward declaration with const
>>
>> You meant doesn't allow? If so, please move the whole structure. I'd
>> prefer code movement rather than removing a const because of compiler issue.
>>
> Yes, compiler does not allow. I will move the code

This is from the specification... if you declare something const you
have to assign the value directly.

>>>
>>>>
>>>> [..]
>>>>
>>>>> diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
>>>>> index 50b9b54..23dac85 100644
>>>>> --- a/xen/include/asm-arm/domain.h
>>>>> +++ b/xen/include/asm-arm/domain.h
>>>>> @@ -116,6 +116,7 @@ struct arch_domain
>>>>>      struct hvm_domain hvm_domain;
>>>>>      xen_pfn_t *grant_table_gpfn;
>>>>>
>>>>> +    struct io_handler *io_handlers;
>>>>
>>>> Why do you need a pointer here? I think can can directly use
>>>> struct io_handler iohandlers.
>>>>
>>>   I just adds to increase the size of this arch_domain struct.
>>> so allocated memory at runtime.
>>
>> Do you hit the page size?
> Yes, I have faced page size exhausted issue which I have reported earlier

Did you still have the issue when you moved out GICv stuff outside?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel