Re: [Xen-devel] [PATCH] xen/arm32: __cmpxchg_mb should be marked always_inline

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/08/2014 03:36 PM, Ian Campbell wrote:
> On Thu, 2014-04-03 at 18:09 +0100, Julien Grall wrote:
>> Currently __cmpxchg_mb is only marked inline. The compiler can decide to not
>> inline this function. In this case, the call to __cmpxchg will be inlined
>> but not optimised. This will result linking failure because of __bad_cmpxchg.
>>
>> Catched by clang 3.5.
> 
> "caught". 
> 
> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> But there is no S-o-b. If you offer one here I'll fix the spelling as I
> commit.

Oops, sorry.

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel