Re: [Xen-devel] [PATCH 1/4] tools: arm: report an error if the guest RAM is too large

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-08 at 15:55 +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 04/08/2014 03:19 PM, Ian Campbell wrote:
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > index 7496556..dc11040 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -369,7 +369,8 @@ typedef uint64_t xen_callback_t;
> >  #define GUEST_GICC_BASE   0x2c002000ULL
> >  #define GUEST_GICC_SIZE   0x100ULL
> >  
> > -#define GUEST_RAM_BASE    0x80000000ULL
> > +#define GUEST_RAM_BASE    0x80000000ULL /* 768M at 2GB*/
> > +#define GUEST_RAM_END     0xafffffffULL
> 
> I didn't catch this on the first read, every other pairs of define use
> _BASE AND _SIZE. Can you be consistent here?

END is what the user of this particular #define needs.

But in any case SIZE gets added later on.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel