Re: [Xen-devel] [PATCH v2 05/15] xen/arm: segregate GIC low level functionality

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

>> +    unsigned int (*nr_lines)(void);
>> +    unsigned int (*nr_lrs)(void);
>
> I don't think we need a callbacks for both of them. 2 unsigned int are fine.
   nr_lines returns number of gic lines supported.
   nr_lrs returns number of LR registers supported.

>
> [..]
>
>> +    void (*enable_irq)(int);
>> +    void (*disable_irq)(int);
>> +    void (*eoi_irq)(int);
>> +    void (*deactivate_irq)(int);
>> +    unsigned int (*ack_irq)(void);
>
> I would prefer to introduce a new hw_irq_controller here rather than
> adding another abstraction.
>
  hw_irq_controller can be used only for enable_irq, disable_irq  & eoi_irq.
other callbacks in hw_irq_controller cannot be used.

Ex: ack_irq in our case returns the irq where as 'ack' callback in
hw_irq_controller
does not return a value. So not suitable here.

>
> --
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel