Re: [Xen-devel] [PATCH] tools/hotplug: Remove network-*

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 09/04/14 11:10, Ian Campbell wrote:
> On Wed, 2014-04-09 at 10:55 +0200, Roger Pau Monnà wrote:
>> On 09/04/14 10:28, Ian Campbell wrote:
>>> These are a xend-ism. Since Xen 4.1 the recommened way to configure 
>>> networking
>>> has been to use the distro facilities (e.g.
>>> http://wiki.xen.org/wiki/HostConfiguration/Networking)
>>>
>>> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
>>> ---
>>>  tools/hotplug/Linux/network-bridge |  339 
>>> ------------------------------------
>>>  tools/hotplug/Linux/network-nat    |  124 -------------
>>>  tools/hotplug/Linux/network-route  |   28 ---
>>
>> Shouldn't you also modify tools/hotplug/Linux/Makefile to remove the
>> references to those files, or am I missing something?
> 
> You aren't, I've no idea why this didn't fail for me before... I suspect
> I just didn't pay close enough attention to the test build.
> 
> -----8<----------
> 
> From 3f2142f0b7a0d600fa8d2d06b5eacf0d52aa5bca Mon Sep 17 00:00:00 2001
> From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Date: Fri, 4 Apr 2014 15:00:12 +0100
> Subject: [PATCH v2] tools/hotplug: Remove network-*
> 
> These are a xend-ism. Since Xen 4.1 the recommened way to configure networking
> has been to use the distro facilities (e.g.
> http://wiki.xen.org/wiki/HostConfiguration/Networking)
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Now it looks fine :)

Acked-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel