Re: [Xen-devel] [PATCH v4 8/8] ioreq-server: bring the PCI hotplug controller implementation into Xen

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.04.14 at 15:42, <Paul.Durrant@xxxxxxxxxx> wrote:
>> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> >>> On 02.04.14 at 17:11, <paul.durrant@xxxxxxxxxx> wrote:
>> > +int gpe_init(struct domain *d)
>> > +{
>> > +    struct hvm_hotplug  *hp = &d->arch.hvm_domain.hotplug;
>> > +
>> > +    hp->gpe_sts = xzalloc_array(uint8_t, ACPI_GPE0_BLK_LEN_V1 / 2);
>> > +    if ( hp->gpe_sts == NULL )
>> > +        goto fail1;
>> > +
>> > +    hp->gpe_en = xzalloc_array(uint8_t, ACPI_GPE0_BLK_LEN_V1 / 2);
>> > +    if ( hp->gpe_en == NULL )
>> > +        goto fail2;
>> 
>> I'd like to ask (also elsewhere in this series) to try to limit the number
>> of "goto"s to the absolute minimum required to help code readability.
> 
> Personally I find using forward jumps to fail labels the most readable form 
> of error exit - I wish they were used more widely.

Interesting - almost everyone/-thing involved in educating me in
programming skills recommended to try to get away without goto
altogether, unless programming Fortran, Basic or some such.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel