[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 01/10] hvm/hpet: Add manual unit test code.

>>> On 09.04.14 at 20:35, <dslutz@xxxxxxxxxxx> wrote:
> On 04/09/14 12:08, Jan Beulich wrote:
>>>>> On 08.04.14 at 16:24, <dslutz@xxxxxxxxxxx> wrote:
>>> Add the code at tools/tests/vhpet.
>>> Does repro the bug:
>>> ..MP-BIOS bug: 8254 timer not connected to IO-APIC
>>> Signed-off-by: Don Slutz <dslutz@xxxxxxxxxxx>
>>> ---
>>>   tools/tests/vhpet/.gitignore |   4 +
>>>   tools/tests/vhpet/emul.h     | 405 ++++++++++++++++++++++++++++++++
>>>   tools/tests/vhpet/main.c     | 541 
>>> +++++++++++++++++++++++++++++++++++++++++++
>> So I'm having difficulty understanding what this is good for, or how
>> it is supposed to be used: You don't add or change any Makefile, and
>> don't say anything to explain how this code is reproducing the bug
>> you mention above. Please be a little more verbose.
> In a xen source tree (with this patch applied):
>    cd tools/tests/vhpet
>    xen_source=../../..
>    sed -e "/#include/d" -e "1i#include \"emul.h\"\n" 
> <$xen_source/xen/arch/x86/hvm/hpet.c >hpet.c
>    cp $xen_source/xen/include/asm-x86/hpet.h .
>    gcc -g -o test_vhpet hpet.c main.c

At least up to here this clearly should be in a Makefile, just like e.g.
done for the x86 instruction emulator test.

>    ./test_vhpet >foo
> Most of this is in main.c's comment.  Will add to commit message also.

Just referring to the comments there would be enough I guess. But
I'm still struggling to see how this would reproduce the Linux side
issue, and not just some random problem manifesting in similar


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.