Re: [Xen-devel] [PATCH v2 10/15] xen/arm: split vgic driver into generic and vgic-v2 driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> Existing vGIC driver has both generic code and hw specific
> code. Segregate vGIC low level driver into vgic-v2.c and
> keep generic code in existing vgic.c file

Just code motion? Please mention this in your commit logs so we know
what to expect (not just for this patch, but generally). If it is mostly
code motion and small small tweaks then it would be really helpful if
you could enumerate then. e.g.:

        This is all code motion except:
              * vgic_{enable,disable}_irqs become non-static so they can
                be called from the vgic-v2 driver
              * somew other change.

That would really help with review, since I can avoid looking too
closely at the code motion bits if I am confident they are really just
motion. (and I have scripts which can help automate it).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel