Re: [Xen-devel] [PATCH v2 12/15] xen/arm: move GIC data to driver from domain structure

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> Move driver specific GIC address information to driver
> header file gic.h from domain.h.

Like with the other gic state I think you can avoid dynamic allocation,
at least for now. (OTOH if you find the vcpu struct is getting too big,
please say)

Does the v3 gic have a different set of addresses?  Actually I see that
you just add dbase_size and rbase to the struct so I'm not sure it
really needs refactoring like this. Either a union or just
        struct ... {
                /* common */
                ... pending_irq
                ... dbase
                /* vgic v2 only */
                ... cbase
                /* vgic v3 only */
                ... rbase
        } vgic
would be fine here IMHO...



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel